Aaron Linville comments

Repositories
Issues
Comments

Results 3 comments of


                                            Aaron Linville

Fixed #24018 -- SQLite backend supports the init_command option

> @linville Thanks for the patch 👍 I can see one issue with this approach, we don't inform users when sth goes wrong. Thanks for reviewing! Could you expand on...

Fixed #24018 -- SQLite backend supports the init_command option

> As in the ticket description, `PRAGMA journal_mode=wal;` return `wal` on success and `delete`/`memory` when it fails. We don't validate the output so a user is not aware that `journal_mode`...

Fixed #24018 -- SQLite backend supports the init_command option

> @linville Thanks for updates 👍 I left small suggestions. Thank you for the review! I believe (hope!) I've got the requested changes incorporated now.