HX L

The cargo_fmt.sh refers to an outdated Rust nightly toolchain.

1

The version nightly-2019-07-03 seems too old.

May need to bind the socket to io looper before executing connect() and listen().

1

Line 683, hpc_network_provider.linux.cpp. If the connection succeeds very fast before binding the handle, is it possible to lose the success event? The same for listen(). We may test this case...

strerror is not thread safe.

2

Here is a ref implementation in file_utils.cpp: ``` c++ namespace dsn{ namespace utils { char *get_error_str(int errnum) { size_t sz = ARRAYSIZE(tls_path_buffer); auto ret = # if defined(_WIN32) ::strerror_s(tls_path_buffer, sz,...

A better one: ``` c++ template constexpr size_t ARRAYSIZE(const T(&array)[N]) noexcept { return N; } ```

If MSMPI or Visual C++ Redistributable for Visual Studio 2015 is not installed on Windows, CNTK Python package fails to run without useful error messages

3

But TensorFlow can notify users the following message: ImportError: Could not find 'msvcp140.dll'. TensorFlow requires that this DLL be installed in a directory that is named in your %PATH% environment...

Use the command 'brew --prefix libomp' to retrieve the location where libomp would be installed on macOS.

1

The following unexpected cases have been tested: 1. brew or libomp is not installed. 2. Homebrew is installed in a location other than the default one, e.g., $HOME/homebrew. 3. Homebrew's...

Thanks!

LG_SIZEOF_LONG should always be 2 on Windows

4

In jemalloc_internal_defs.h, sizeof(long) is always 4 on Windows no matter x86 or x64 is targeted. BTW, _WIN32 is defined for both x86 and x64 targets. So _WIN32 alone cannot be...

The Makefiles under `preload/posix`, `preload/run`, `tests`, and `tests/generated` folders handled `ALL_CFLAGS` inconsistently. Update them to follow the same pattern used in `libfiu/Makefile` for consistency.

When building libfiu on Debian 13 aarch64 with the following command: ```bash make V=1 DEBUG=1 TRACE=1 POSIX_TRACE=1 tests ``` the test programs (e.g., `test-enable_stack_by_name.c`) enter infinite recursive calls (e.g., in...