valentin richard

Results 27 comments of valentin richard

Well actually, I didn't find any subject or topic asking for a `.matches` with the possibility to specify a `:scope`. It seems that the `:scope` selector is not used frequently,...

Ok, so as you commented: ```js // FIXME Does not account for escaped backslashes before a quote selector = selector.replace(/(['"])(\\\1|.)+?\1/g, (str, quote, content, start) => { ``` Actually this regexp...

Note: the regexp can't handle `\\\\` (ex: `"ab\\\\"hg"`). Actually I guess a regexp can't handle properly every escapes and quotes in string. For this a proper parser may be used.

Hi, any news ?

Well, origin (second argument) should not contain any path. This is an error on your side even if some browsers allows it. Second, domain name are lower-cased, this is normal...

Yes, this is a legit behavior: the introduction of Symbol.iterable is pretty recent, just like classes/functions accepting them as input. This polyfill currently doesn't support iterables as input to support...

The test are currently running on my own selenium test server. You may change the url here: https://github.com/lifaon74/url-polyfill/blob/master/tests/config.json You may try to update the code, verify if everything works on...

Should be fixed. It seems you're polyfilling URLSearchParams from another piece of code, else this would't append. All tests are passing. Both URL and URLSearchParams are closely correlated and cannot...

Wow, hopefully you noticed it, I forgot to publish the last version. Could you please check than the 1.1.1 is now working ? Thanks for your help.

Ok I commit a version that should work on safari. Could you test it please(1.1.2) ?