Benchao Li

Results 19 comments of Benchao Li

@wanda1416 Thanks for your contribution, I can review this. However, before that, I would like to hear @NobiGo 's opinion since he is the original reporter and assignee of this...

I found that there is a similar work before: [CALCITE-4888](https://issues.apache.org/jira/browse/CALCITE-4888). @beyond1920 What do you think about this? I think we can add you as a co-author of this issue since...

@abhishek-das-gupta I found that `RexBuilder#makeBetween` also may have the same problem, could you help to confirm this, and fix it if it exists? (In this issue, or a follow-up issue,...

fixed via https://github.com/apache/calcite/commit/43db14cf8e08230c309eeb425a568e77db964a46

@wangyeweikuer Thanks for your contribution, could you add some tests which will fail without your fix? This will make us easier to understand the PR.

@qingwei91 Thanks for your contribution. For the current design, I see you use `ValueLiteralExpression#toString()` to generate the string for literals. This may work for some cases, but not for all...

> I believe JdbcFilterPushdownVisitor needs to produce strings or some equivalent data, so that it can be used by JdbcDynamicTableSource::getScanRuntimeProvider, how should I make use of PrepareStatement here? Maybe I...

> I believe IN is supported out of the box, because Flink compile IN into multiple X=Y condition chained together by OR Not exactly, we have a threshold (default 4):...

@qingwei91 Thanks for the updating, I'll review this PR in a few days. > I didn't implement additional operators like IN and BETWEEN because I am quite busy of late....