Lianet Magrans

This is the task to closely follow https://issues.apache.org/jira/browse/KAFKA-14517, where the broker will support the new regex.

Hey @Phuc-Hong-Tran , regarding the mixed usage of subscribe with `Pattern` and with `SubscriptionPattern`, my opinion is that it is something we should live with to provide a smooth transition,...

@Phuc-Hong-Tran regarding this: > Just for clarification, when we were talking about "implement and test everything up to the point where the field is populated", does that mean we're not...

This LGTM @cadonna , left comment above discarding one of my messages, the test is clear enough. Only [this](https://github.com/apache/kafka/pull/15408#discussion_r1591300734) other nit above about the test class description but I'll bring...

Hey @kirktrue , took a first look and overall it looks good. Is there a run of the system tests with this change? (agree that failures in PlainTextConsumer are unrelated...

Hey! I just pushed all the requested changes. The most important change is addressing @AndrewJSchofield 's [comment](https://github.com/apache/kafka/pull/16885#pullrequestreview-2247401944) regarding timeout handling, totally agree. > Couldn't the OffsetsRequestManager simply make the sequence...

Thanks @AndrewJSchofield! Very helpful review. @chia7712 any chance you would have time for this one? Thanks!

Hey @chia7712 , thanks for the review! All comments addressed

Hello @chia7712, thanks for the comments! All addressed.

Hey @chia7712 , I just added a small fix https://github.com/apache/kafka/pull/16885/commits/2957cc49f1b7fdec96f278325066d04c1152815f after noticing some suspicious failures in the tests after the previous changes. I was indeed missing the fact that we...