Liam Bao

Results 8 comments of Liam Bao

> I remember previous attempts to remove TableSchema from Flink are failed. Could you please check if we were able to backport these changes to Flink 1.19/1.20? Hi @pvary, thank...

Made the same change for Flink 1.20, tests passed locally. Please take another look, thank you @pvary @mxm!

@pvary Yep, my plan is to first remove `TableSchema` from `IcebergSource`. After that, I’ll deprecate the remaining methods in `FlinkSchemaUtil`, followed by deprecations in `FlinkSink` and `IcebergSink`. I’ll also clean...

> What are the obstacles for completely getting rid of TableSchema? Hi @mxm, do you mean removing all usages of `TableSchema` in a single PR? I think that would result...

Hi @mxm and @pvary, this PR is ready for review. I’ve fully removed/deprecated the use of `TableSchema` in Flink 2.0/1.20. The changes are split into four commits: `IcebergSource`, `FlinkSchemaUtil`, `FlinkSink/IcebergSink`,...

Hi @alamb, from the upstream ticket, I think we can use `resolve_bucket_region` to get the region if it's not specified. However, I'm wondering what should be the expected behavior if...