Lindsey Gray

Results 188 comments of Lindsey Gray

Just to add more to this, I've been using torch 1.6 throughout its development period, including the RCs. Never any problems.

Just to note - to fix #8942 could you please remove the sentries in type dict that cause sets to raise an exception as dict keys/values? If using typed Set...

Hey, so trying out the code in my issue works pretty well, thanks a lot for this! I ran into a few snags. Here's the functioning code: ```python3 import numba...

I also had to make a change to the sentry in python to allow dict to accept sets as arguments: ```diff diff --git a/numba/core/types/containers.py b/numba/core/types/containers.py index 243988abc..fe0338df4 100644 --- a/numba/core/types/containers.py...

@kc611 is there any more information you would like in order to proceed?

@stuartarchibald Got it, then I think it may be functioning incorrectly because I could not create typed dicts (with the patch in this PR) with a set in them. Perhaps...

This corresponds to a ~20% improvement in execution time (O(1s) out of 5s) building a single task graph in the workflow in question, so this is a rather significant improvement....

Just to link to the wider discussion: https://github.com/dask-contrib/dask-awkward/issues/468

Yes it is still useful in case people are sticking awkward arrays directly in the graph.

Since the operation I mentioned is something you do *outside* of dask awkward there are no tests in dask awkward for it.