Lukas Gienapp

Results 4 comments of Lukas Gienapp

Unsure what to do about the failing [mypy test](https://github.com/Lightning-AI/torchmetrics/actions/runs/7960218622/job/21728871169?pr=2392) - assigning the lambdas to overwrite the original class methods seems to be the most straightforward solution to supplying user-defined behaviour...

Some unit tests check for error messages via regexes, and these had to be adapted to the typo fixes as well. Should all pass now.

Establishing a general class sounds good. Just for clarification: the general `MetricInputTransformer` would still subclass the `WrapperMetric` to inherit all the "reset-sync" code from there (e.g., live in `torchmetrics.wrappers.transformations`)? Or...

Its on an unmerged feature branch still, as per https://github.com/AnswerDotAI/ModernBERT/issues/155#issuecomment-2579563363: https://github.com/AnswerDotAI/ModernBERT/blob/pretraining_documentation/yamls/main/modernbert-base.yaml