caozhiqiang

Results 7 comments of caozhiqiang

@jojochuang Could you help to review and merge this patch if you have time? Thank you.

@Hexiaoqiao Thanks for your review! The failed unit test is org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner and I think it's not related to this PR. I will add another UT.

@Hexiaoqiao I have add new UT to cover this case, and please review again. Thanks!

@haiyang1987 Thank you for your suggestion. I have update the UT.

@zhengchenyu I think it's wrong you described about pendingReconstruction. The block flow in decommission is: (1)DatanodeAdminManager::monitor --> (2)neededReconstruction --> (3)PendingReconstructionBlocks::pendingReconstructions --> (4)PendingReconstructionBlocks::timedOutItems--> (5)neededReconstruction If reconstruction task failed in dn, block...

@zhengchenyu We should check (1) -> (2), but not (4) -> (5), because (4)->(5) is not only used in decommission flow.

@Hexiaoqiao @haiyang1987 Hi, Could this commit be merged?