levirak
levirak
I suppose a bit more of a comment is warranted. This integrates the [OSS-Fuzz-targets](https://github.com/wolfssl/oss-fuzz-targets) repository into wolfSSL as a subdirectory. This allows us to implement a thin front end (fuzz/target_main.c...
It looks like that's quite explicitly intended in [`RollTree.buildRoll()`](https://github.com/foundryvtt-starfinder/foundryvtt-starfinder/blob/78cace8fd423f44f444d36a0080bcfd98f2cbddc/src/module/rolls/rolltree.js#L65-L76): ```javascript const finalSectionFormula = foundry.utils.deepClone(finalRollFormula); if (finalSectionFormula.finalRoll.includes("")) { const damageSectionFormula = part?.formula ?? "0"; if (part.isPrimarySection) { finalSectionFormula.finalRoll = finalSectionFormula.finalRoll.replace("", damageSectionFormula);...
It is more tempting than in should be to be offered the roll code. It would be... ambitious... of me to attempt a re-write, especially as a newcomer to the...
This PR looks very similar to #1345, which got closed by @LebombJames "after our discussion." What's the difference?
Glad to hear. I mostly asked just to get an explanation on the record. > we need to push these changes to make it work for non-windows devs Correct. I...
`npm run build` works\*, but `npm run unpack` fails. \*But I still have my issues with the implementation. For build, both the original and this build file do string substitutions...
Can you please enumerate some objects you're interested in and what you'd like done with them? It sounds like you're at least interested in `JournalEntry` and `JournalEntryPage`. The only thing...
Gotcha. So the only thing you need is for sfrpg's hook to silently ignore dropped data that isn't an item.
I double-checked with sweetrpg/lootparcels-foundryvtt#83, and it looks like this issue is not yet resolved. Digging in a bit deeper, it looks like the root problem is that SFRPG needs to...
As a heads up, I've force pushed over my previous branch. My previous job got me into the habit of rewriting history quite aggressively. I'm trying to structure the commits...