Leon Ziyang Zhang

Results 6 comments of Leon Ziyang Zhang

Thanks @mreiferson Yes I understand it's out of the scope of the original design but with the added strategy of discarding old data, it'll enable many more use cases-) If...

Thanks for the follow-ups! We've implemented a disk size limit in this [fork](https://github.com/kev1n80/go-diskqueue#disk-space-limit-feature) It added new matadata (e.g. number of msg per file) to keep accurate track of depth when...

The proposed 2 items won't make the logic more complex as they are pretty trivial to add to the current structure. The breaking part could be mitigated by a optional...

> > [The current version of this specification (00) only supports a single flag called sampled.](https://www.w3.org/TR/trace-context/#sampled-flag) > > > [The behavior of other flags, such as (00000100) is not defined...

> This will need a changelog entry. > > Also, while this change looks good, I think I recall a discrepency in the specification. I can't find that anymore though....

Hi @MrAlias friendly reminder in case you missed the comments.