Leon Senft

Results 66 comments of Leon Senft

I'm considering trying this before #2624, but it's unclear to me where such errors should be handled in `build_runner` and `bazel_codegen`. `build_runner` (and friends) in particular has so much indirection...

Great, thanks for the help! One last quick question before I get started. The proposal suggests an `Error` (based on the name), but this would be better suited as an...

> Some other options for completeness: > > * Stop printing stack traces by default and only print them when some option is passed @natebosch Is this effectively done now?...

In that case, what differentiates an exception that is specifically a `BuildFailure` versus one that is not? Won't both be caught, logged, and have their stack trace shown depending on...

I ran into this issue and I think the root cause is `LiteralListExpression.toString()`'s implementation: https://github.com/dart-lang/code_builder/blob/743cb0a9f40079ff76fa45a6c2cb7d59a7ec4ad6/lib/src/specs/expression/literal.dart#L137 It passes each value to `literal()` which is what throws the reported error: https://github.com/dart-lang/code_builder/blob/743cb0a9f40079ff76fa45a6c2cb7d59a7ec4ad6/lib/src/specs/expression/literal.dart#L35 I...

Thanks for the detailed repro @grundid. I'm unable to reproduce the exception internally. It's possible there are changes to package:angular_components that haven't been published yet, or an issue in the...

@grouma this has been the cause of several unique unhandled exceptions in the Angular compiler.

I understand that, but perhaps it would make sense to throw an explicit error instead of knowingly failing a null check. For now, I'm creating an extension method to wrap...

I've run into the following issue working on this. Before, you could query for a base type via reference, and have it match derived types. ```dart @ViewChildren('tab') QueryList tabs; ```...

@zoechi The issue is inference doesn't work with inheritance currently, and if you set the read token explicitly it won't work with inheritance for the same reason. Consider this case....