Franz Louis Cesista
Franz Louis Cesista
If I'm not mistaken, merging the topic with -1 would "delete" it in a sense, but the ordering of your topics would change too. ```python topic_model.merge_topics(docs, topics, [-1, topic_to_delete]) ```
Hi, @raphaelreimann and @MaartenGr! I just pushed a PR for the fix here: https://github.com/MaartenGr/BERTopic/pull/694
ping it still does not work :(
@eitanturok I don't think this is a bug cuz we don't use the title field when building the FSM (& when generating outputs) Can you provide an example where this...
@eitanturok, we should raise this as a separate issue I'm thinking of replacing this line in `get_schema_from_signature` ```python model = create_model("Arguments", **arguments) ``` with ```python model = create_model(fn.__name__, **arguments) ```...
> @rlouf After inspecting a little bit, `generate.cfg` first should be fixed since it has a bug. > > The `def copy(self) -> "CFGGuide"` should just return `self` instead of...
@miftahmoha @rlouf It's not a good idea to return `self` in `def copy` cuz then we'd end up using the same fsm for all prompts in the batch. See: https://github.com/outlines-dev/outlines/blob/4f8433d8d6633b0780c3a6c27981f9adffbe49f5/outlines/generate/api.py#L189
IMO it's better to add another method, say `def deep_copy`, which returns `CFGGuide(self.cfg_string, self.tokenizer, self.refex_fsm, ...)` and use that instead in `reorder_fsms` (and just in `reorder_fsms` for now) Alternatively, we...
@lapp0 @rlouf How do you guys think should the interface look like? --- Here, I mirrored Huggingface's Pipeline interface where we can specify configs/args in the constructor and (optionally) override...
@rlouf yup! I just deprioritized this in favor of other stuff; I'll get back to this soon btw, thanks for the feedback, @alonsosilvaallende!