Gianni Moschini

Results 19 comments of Gianni Moschini

see https://github.com/coderholic/django-cities/pull/203

Are you saying you think this change affects the failing test? > AttributeError: /usr/lib/libgdal.so.1: undefined symbol: GDALGetMetadataDomainList Doesn't sound like this failing error has anything to do with this change

https://github.com/coderholic/django-cities/pull/209 Is that it?

I noticed when the `isSubmitting` is set back to `false` (after submit), the `Persist` component doesn't seem trigger a component update. I tried checking the comparison in [componentDidUpdate](https://github.com/jaredpalmer/formik-persist/blob/d22ffb00ed25a480305009148bef4b25847b9087/src/formik-persist.tsx#L28) to see...

The [readme](https://github.com/HerringtonDarkholme/yats.vim#config) mentions explicitely to set the regex engine via `set re=0` > Note: `set re=0` explicitly in your vimrc. Old regexp engine will incur performance issues for yats and...

I assume it won't work, as in regression and result in no style applied (using whatever the default was) I would vote for doing the change and losing compatibility for...

I've created an alternative PR that only adds the style, rather than just updating it (to keep backward compatibility): https://github.com/s-block/django-nested-inline/pull/114 Feel free to decide which one is best, and close...

might be included in Django forms, but it isn't in django-nested-inline forms https://github.com/s-block/django-nested-inline/blob/95819fc1d240225b351fb200fe60d97e37f8f2b3/nested_inline/admin.py#L50 I wouldn't make a PR for an issue I'm not having :)

Fun fact, to actually make sure django jQuery is loaded, one needed to set `JQUERY_URL = None`, otherwise this never enters: https://github.com/jazzband/django-smart-selects/blob/fec2209d940c2894aec7db0a37cd74b19d4df6a1/smart_selects/widgets.py#L37 But I can't see this documented anywhere. Apparently...