Wu-Jung Lee

Allow handling larger-than-memory total data volume in `combine_echodata`

2

In one of our `echopype-examples` example notebooks (the OOI one), the kernel would die if local memory is not large enough to hold the total volume of data from all...

`combine_echodata` review and debug

1

This serves as the tracking issue for all existing issues related to `combine_echodata`: - [ ] #678 - [ ] #704 - [x] #705 - [ ] #766 My thought...

Create default artificial test objects/datasets

1

Increasingly we have the need to unit test functionalities that are higher on the processing chain and many of the current tests right now need to go through the convert-->calibrate...

Add test for calibration output format consistency

2

From @emiliom 's comment in #735: > The form of the resulting Sv, after conversion and calibration, should be identical regardless of the source raw data type; if it's not,...

Add option in `consolidate.add_depth` to use variables already in EchoData

3

Right now `consolidate.add_depth` accepts only scalar inputs for input arguments `depth_offset` and `tilt`. However, these two variables can conveniently be DataArray with a time dimension. Or we may want to...

Coordinate `filenames` of data variable `source_filenames` should be a coordinate

1

I am just working with the calibrated Sv dataset and trying to combine many of them, and I noticed that the `filenames` is a dimension but not a coordinate. This...

Right now we set all negative `echo_range` to 0 at the end of `compute_range`, which causes problems when trying to combine datasets (#578) https://github.com/OSOceanAcoustics/echopype/blob/12693a72badcf54a18408e694b72e7b0e6d48023/echopype/echodata/echodata.py#L473 This issue is a reminder to...

Proposed reorganization of AD2CP data format

2

In v0.6.0 we left out AD2CP data because it takes quite a different flavor from all the other sonar models. Now we are in the position to reorganize the data...

While working on #547 I noticed that the tests for `echodata.compute_range()` at the moment only check if the method can be executed successfully. We should test for the actual computed...

Right now our tests for `compute_MVBS` are pretty messy and we can benefit from reworking this for robustness and readability. A laundry list of the few things I noticed while...