leaty

Results 22 comments of leaty

Sorry, I should've been more specific. I was asking about something akin to the `waitUntil` argument in puppeteer's `waitForNavigation`, see [link to docs](https://github.com/puppeteer/puppeteer/blob/v8.0.0/docs/api.md#pagewaitfornavigationoptions). Although I don't particularly appreciate the closed...

Informative response, thank you! > you could subscribe to the events you're interested in on the Target, that should give you access to that information. If I understood this right,...

Oh and if you know by hand what would need to be changed for `use` and `for` (this is rust btw), please let me know! Those seem to be the...

I assumed performance would take a hit but not by that much, thanks for commenting. I totally agree with you that it's undesirable. As I mentioned it would have to...

> I don't have time to really dig into this right now That's absolutely fine, no need to rush. It was more a "should I elaborate for upstream or not"...

Thanks for the quick reply. All of what you said makes sense, apologies for the poor (and quite clearly broken code). I just needed this to work quickly and I...

> I wonder if it makes sense to re-use the current `escape` option Yes, I'm all for reusing that. I also think it's better if it's only enabled when quoting...

Sounds good, I'll give it a go this weekend :+1:

I must be misinterpreting something, I really thought something like this would work. But it's still interpreting the `,` as a delimiter after a `\` and giving me `UnequalLengths`. Any...

Solved by moving escape out from under quoting: https://github.com/BurntSushi/rust-csv/blob/91998f68c0c6b3b6ea77eb7307115f51cfba9aae/csv-core/src/reader.rs#L807-L812 However, while this doesn't give an error and partly works, it's removing the escaped `,` E.g. ``` field1,field2,field3\, with\, commas,field4 ```...