Leandro Lanzieri

Results 61 comments of Leandro Lanzieri

This must be the only PR which we want to fail and keeps passing...

> but it doesn't work since the BOARD_VERSION variable in boards/esp32s3-devkit/Makefile.features is set to default if not defined at command line before Kconfig is used. > Do you have any...

> `BOARD_VERSION` environment variable is used in `boards/esp32s3-devkit/Makefile.features` to select the `CPU_MODEL` variable. If `BOARD_VERSION` is not set, it iis set to `esp32s3-devkitc-1-n8` by default and the `CPU_MODEL` is set...

Looks like you caught a difference in the module list that was not impacting the binary hash

> It seems the failures are caused by `periph_gpio_ll_irq_unmask` included in every make build. The seems a bit wrong so I adapted the make to only bring it in when...

Thanks for tackling this @MrKevinWeiss !! I took a look and changes seem reasonable. Please go ahead and squash!

> What whould be a better place from your point of view? I would expect to see this maybe in `System > Networking > WiFi`. One thing that can be...

> As long a there is no other WiFi netdev driver I would leave the symbols as they are. OK? The problem with having the ESP specific symbols is that...

> I couldn't find `Kconfig` for LoRaMAC. Sorry, I was just referring to the fact that they have generic `LORAMAC_` macros that are used both by the Semtech package and...

> > > As long a there is no other WiFi netdev driver I would leave the symbols as they are. OK? > > > > > > The problem...