Leandro Braga

Results 13 comments of Leandro Braga

I've got the same issue while viewing a one-liner file with ~500k characters (~0,5 MB file). The issue disappeared after I formatted the file, which introduced newlines. Helix version 23.10.

I did some work today and managed to write a failing test for it: ```python @patch( f"{get_best_parameters_from_model_predictions_with_trial_index.__module__}" + ".assess_model_fit", wraps=assess_model_fit, return_value=AssessModelFitResult( good_fit_metrics_to_fisher_score={"x": 1}, bad_fit_metrics_to_fisher_score={}, ), ) def test_get_best_point_with_model_prediction( self, mock_assess_model_fit,...

I managed to type annotate the `faster_fifo.pyx`, but didn't manage to export the types correctly to the library user. The following code can be transformed in a `.pyi` file, or...

> That's more or less the job of a formatter. The cases you describe are going to be affected by how the language is defined. For instance, how can you...

May I be assigned to this issue? I'm new to the codebase, so my first implementation might be a bit rough and I may need some maintainer help to iron...

OK, I'll use `RUF069`. I have a question: is removing the duplicate entry a safe fix?

Thank you for your input, @ntBre, it was really helpful. I wasn't aware of [fix safety docs](https://docs.astral.sh/ruff/linter/#fix-safety) nor the comment in the range pattern.

It seems that those are all true positives. This one might even be a bug. https://github.com/python/typeshed/blob/06ecffccc72423711137c07be80c90522c084bbe/stubs/reportlab/reportlab/lib/rltempfile.pyi#L1-L4

> What about these cases? > ```py > import typing > > > class A: ... > > > class B: ... > > __all__ = "A" + "B" >...