Lee Bernick

Results 256 comments of Lee Bernick

/reopen I am also running into this issue with the following pipeline: ``` apiVersion: tekton.dev/v1beta1 kind: Pipeline metadata: name: build-and-push spec: workspaces: - name: source-code tasks: - name: clone taskRef:...

I just experimented with modifying the readiness probe, but it looks like Tekton is actually not waiting for the sidecar to be ready before starting the steps; here's some output...

Ok, it turns out this is not an issue with the readiness probe, it's an issue with `insecure_registry`. The default value for insecure_registry is "", which causes the sidecar to...

One option could be having a sidecar_extra_args param (similar to the build_extra_args and push_extra_args params). However, replacing insecure_registry with sidecar_extra_args wouldn't be backwards compatible. I'm not sure of a good...

Looks like docker authentication is also not configured correctly in this task. [here's a version](https://github.com/lbernick/tekton-codelab/blob/b725ca65c203f352556d82de9c2a7794fefeefb2/docker-ci-example/build-task.yaml) I hacked together that works with Google Artifact Registry.

/priority important-longterm

/priority important-longterm