Laurents Meyer
Laurents Meyer
I think there is a lot of merit to this.
Currently, there are no Connector/NET benchmarks at all. (I have only added some in my local repo for comparison purposes.) Independent of, whether Connector/NET benchmarks should be added as well,...
I wasn't even aware, that there ever were Connector/NET tests :)
I got the same error, while I was testing my application in a VirtualBox VM. As it turned out, previously to testing the application, I had been dragging and dropping...
I absolutely agree. Is this project still active or can we just deprecate it? In case it is still active, I propose we change the name and then first deprecated...
> If that were the final answer, would this break anything in Pomelo, or would you just have to override those base class test cases to expect a different result...
> Every bug fix is a breaking change for people who were depending on the buggy behaviour. 😀 That is true. But the primary issue I see here are not...
> 1. Wouldn't real-world code have called `ExecuteReader` anyway (to read the result set)? Probably yes, unless the code does not care about the final `SELECT` result (like the tests)....
It is probably best to make sure first, that we are actually talking about the the same issue here, because we might not. So let's start from the root of...
> It's not a "regression bug" (which I would define as a change from correct to incorrect behaviour) [...] That is fair. > Pomelo doesn't read the `RecordsAffected` property: https://github.com/PomeloFoundation/Pomelo.EntityFrameworkCore.MySql/search?q=RecordsAffected...