Adrian Górny

Results 12 comments of Adrian Górny

This evening or tommorow evening I'll release pull-request with it :)

#208 ping @egeloen

@egeloen sure cookbook should be sufficient for this case, I can understand your POV. Although there are some basics lacking in current documentation so perhaps it would be wise to...

As soon as i get back to the project that utilizes your library i will add sth from myself, currently i will have trouble to find time :( perhaps someone...

Glad I could help :)

Yeah that's what I'm worried about. By external I mean generating a route to "idp.example.com" from "sp.example.com".

Truth to be said I'm using symfony 3.x right now :) I can post a PR after I fix it for my project but it requires documentation changes too. And...

Well perhaps we can manage to do it with oneliner like this: ```php return new RedirectResponse($this->httpUtils->generateUri($request, $redirectUri), 302); ``` instead of ```php return $this->httpUtils->createRedirectResponse($request, $redirectUri); ```

Well, that's certainly a point and probably a reason why Symfony entered this. Therefore there's nothing to include in a bundle except for a change in docs perhaps. The httpUtils...

Hmmm, isn't it a potential security breach if they add a method like 'setDomainRegex" or simply 'setHttpUtils' to authenticator class? I think the best approach would be to abandon "createRedirectResponse"...