Hongfei Ding

Results 15 comments of Hongfei Ding

@ankikala thanks for creating this. high level, AMP does not allow loading custom javascript in the main window. are you able to integrate using the `amp-link-rewriter` extension: https://github.com/ampproject/amphtml/blob/master/extensions/amp-link-rewriter/amp-link-rewriter.md

Here is the design doc link: https://docs.google.com/document/d/15XPbRPCnkqFCr9Bjrdu3cP8aMMJfMtOy0f1bkxR26J4/edit

@vigneshcamar & I met again to dive deeper into the design. Notes pasted here. @vigneshcamar feel free to correct me or add things. - Amazon OneTag is the solution for...

@vigneshcamar we could have all links sent to your server (in a privacy friendly way) while fetching the link-rewriter config. you server will rewriter each link at server side and...

Something like [this](https://docs.google.com/document/d/19HWdYVA31fW4bLNKm0JrWS1YoWtNIQK1JV8yb5oK5u4/edit#)

@lazharichir sorry you might find wrong person. I don't even know what AALB is. If you find an issue with AMP, please create a separate issue. This thread is about...

hi @vigneshcamar sorry being late. I'm glad you're back on this. Sure, I will still be your point of contact. What is CR phase though?

yep, you can assign code review to me and I can help to reroute if needed.

are you use the xhr util to send request? you can pass along 'credentials: include' as params. https://github.com/ampproject/amphtml/blob/06123ab062b2be8d04bdb3e232c7c02a8cffe09b/extensions/amp-access/0.1/amp-access-client.js#L133-L135

thanks @zombifier for the screenshot! I know what happened. Will fix.