L

Results 10 comments of L

I realize now that I could get the config setting in this manner: ```ts let testModuleConfig: NonNullable; ``` ...but that can quickly become burdensome as the number of tests increase.

> Just for clarity, are you saying the relay-connection-types-spec rule is preventing you from defining interface Connection or are there more issues? Will your connection types still end in Connection?...

I appreciate the openness. I'll take a stab at the implementation, probably, tomorrow.

I'd prefer them hosted outside of the repo. Decrease size.

Cool! I finally have time again to work on this and I've already started a rewrite. I will incorporate this into it! I'll give this a shot sometime this week....

Thanks. I should have some time this weekend to throw this in. :)

I'm not too familiar with the presets option. I've just been keeping parity with https://github.com/reactjs/express-react-views/blob/master/index.js. That said, if you think it's not too far a leap from `express-react-views` then please...

This library does not use environment variables for settings. https://github.com/reactjs/express-react-views/blob/master/index.js#L60 ```js const options = { settings: { env: process.env.NODE_ENV || 'development' } }; app.engine('jsx', require('express-react-views').createEngine(options)); } ```

I never had a problem with speed until recently, since latest VSCode update. Navigation (J,K, etc) is basically unusable. Insert mode movement is fine. VSCODE: Version 1.26.1 (1.26.1) OSX: 10.13.6