Eduardo Salinas
Eduardo Salinas
Minimize what needs to be included and avoid conflicts with other header files like winsock2.h.
avoid possible multiple definition linker error Not sure why it was omitted, you might have a good reason. Let me know if there is more context of if I'm missing...
This is a proper fix for the problem patched in https://github.com/VowpalWabbit/vowpal_wabbit/pull/3998 but for gd only. Also related: https://github.com/VowpalWabbit/vowpal_wabbit/pull/4020 - adds an std::vector holding instances of state that is per model,...
``` `Failed TestSharedModel [1 s] CUSTOMBUILD : error Message: [D:\a\vowpal_wabbit\vowpal_wabbit\vw\build\test_with_output.vcxproj] Test method cs_unittest.TestCbAdfClass.TestSharedModel threw exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other...
now: ``` -Action^fff*User^a:431:-0.0420591 3.99279 1 -Action^fff*_ccb_slot_index^index1:1661:-0.0545174 4.26212 1 -Slot^h*User^c:2034:-0.0509719 1.3541 1 -User^a*_ccb_slot_index^index2:2511:-0.0336862 2.16077 1 ``` with hexfloat: ``` +Action^fff*User^a:431:-0x1.588c6p-5 0x1.ff13a2p+1 0x1p+0 +Action^fff*_ccb_slot_index^index1:1661:-0x1.be9b4p-5 0x1.10c68ep+2 0x1p+0 +Slot^h*User^c:2034:-0x1.a18fecp-5 0x1.5aa682p+0 0x1p+0 +User^a*_ccb_slot_index^index2:2511:-0x1.13f518p-5 0x1.14941ap+1 0x1p+0...
implements #1895 - [x] happy path - [ ] cache debug
https://github.com/VowpalWabbit/vowpal_wabbit/blob/6d7193a0ff440af55403356bfacbd4f45df7bbd1/test/runtest_coverage.py#L111 These tests cause failures with pyvw, no known cause. Could be similar to the exempted tests in the c# run. These tests do not run on CI, but its...