Matt Kowalczyk
Matt Kowalczyk
lesson learned, check "issues" and count how many are tagged with "bugs" before adopting. what an embarrassing bug.
https://code.visualstudio.com/docs/getstarted/settings#_default-settings link to the config docs as it's not a boolean type as the comments above suggest. the config accepts "never", "always", "selection"
thanks! i'll be able to review in a few days.
hey, are you able to share the benchmark that you're running?
sorry i stepped away from this for a few months. i'll be reviewing this once again.
Overall, this looks great. I just have some concerns around the two areas I commented above.
Ideally, we would vendorize the Base64 class and include it in the project. Are you familiar with any other android issues?
it means to include the code in the project so both android and non-android platforms can be supported. we essentially remove the dependency from the standard library. however, this approach...
correct, but again, all dependencies must be identified since some may be more feasible to include than others. in the event that a dependency cannot be easily included, this approach...