Khoa Vo
Khoa Vo
What is the permissions that this app need? Do you assume that it should run as admin?
@Keralin What do you mean "in your case"? Are there different use cases? I read that only the default serviceAccount is mutated, so do we really need all the permissions...
I think this is a simple but crucial feature. Sometimes you need to stop the build in gha before it does something stupid. But since now codebuild will continue anyway...
We tried adding `storage_config.aws.http_config.response_header_timeout: 5s`, which eliminates the issue when queriers restart. However, issues still happen every once in a while. It's hard to know exactly when, but I observe...
Update on this: We have since found and fixed other issues, our Loki has been working stably for a while now. Even so, I'm keeping this because we still haven't...
Sorry, misclicked 😄
> > Update on this: We have since found and fixed other issues, our Loki has been working stably for a while now. Even so, I'm keeping this because we...
Please also use checked exception for common errors such as a missing label, so that production servers don't blow up at runtime when a counter is incremented.
> instrumentation should be lightweight Agreed, everything should be lightweight, but sadly that's not the reality isn't it? So your solution is to use unittesting. You expect that my code...
Well I said "missing label" but sure, I wasn't clear enough. The point about null labels still stands, though.