Alexandros Lamprineas comments

Results 34 comments of


                                            Alexandros Lamprineas

Add FMV feature names priority[ABCDE]

@DanielKristofKiss can you please explain a little more as I am not sure I understood. Are you suggesting we use an explicit priority syntax like the one for example in...

[FMV][AArch64] Do not emit ifunc resolver on use.

> It's really hard to tell what is changing here because the existing tests are so non-specific. I appreciate that. The tests would benefit from some tidying up, we should...

[FMV] Allow multi versioning without default declaration.

I think I messed up the review, this is based on #84405 so it shows unrelated changes. Ignore for now. I'll rebase

[FMV] Allow multi versioning without default declaration.

Hmm, I am now having second thoughts about this change. All is well without a default declaration as long as we don't have a caller in the TU. In that...

[FMV] Allow multi versioning without default declaration.

Update: The ACLE spec is now explicit about this (see https://github.com/ARM-software/acle/pull/310), so we can safely implement the change in the compiler. Implementation-wise I have moved the static cast to `llvm::Function`...

[FMV] Improve test coverage for FMV features.

We may need to change the negative tests because in some cases the kernel disables the detection of features and as a result the tests UPASS (see https://github.com/llvm/llvm-project/issues/109304).

[FMV][AArch64] Document the interface for Function Multi-versioning.

ping

[FMV][AArch64] Document the interface for Function Multi-versioning.

Adding @jroelofs for visibility

[FMV][AArch64] Document the interface for Function Multi-versioning.

Thanks for reviewing!

[FMV][AArch64] Document the interface for Function Multi-versioning.

After further digging we found that the `__aarch64_cpu_features` global is used by `__builtin_cpu_supports` and the runtime library for SME. These two rely on constructors which run after the resolvers have...