Kazuyoshi Kato

Don't use hard links in runc jailer

6

firecracker-containerd uses hard links in runc jailer. However making a hard link doesn't work if its destination and its source are in different partitions. We need to either 1) document...

Improve error message when VMs are absent

2

Right now, it may only return `ttrpc: closed: unknown`. We probably should return something more meaningful/helpful.

TestMultipleVMs_Isolated is still flaky

2

https://buildkite.com/firecracker-microvm/firecracker-containerd/builds/2535#8267eaab-d952-4276-a956-c304790b50b0 ``` === RUN TestMultipleVMs_Isolated service_integ_test.go:263: TestMultipleVMs_Isolated: will run 100 vm's service_integ_test.go:450: Error Trace: service_integ_test.go:450 Error: Received unexpected error: unexpected errors from VM 76: failed to create a VM while...

volume: Can't we have a uniform interface for normal containers and in-VM containers?

1

https://github.com/firecracker-microvm/firecracker-containerd/pull/631#pullrequestreview-979369783 > I think this is fine for now, but I'd like to see a follow up (maybe just an issue for now) with a deeper dive on if we...

For example, if our tests leak loopback devices, we wouldn't notice that since our BuildKite instances are replaced regularly.

Update and add more information on docs/architecture.md to reflect the current status. https://matklad.github.io/2021/02/06/ARCHITECTURE.md.html is good guidelines about what we could put in the document. > I find ARCHITECTURE file to...

Something like https://github.blog/2020-12-16-reducing-flaky-builds-by-18x/?

We probably should cache critest and Firecracker's binary artifacts to speed up our build.

https://github.com/firecracker-microvm/firecracker-containerd/runs/5250770611?check_suite_focus=true ``` --- FAIL: TestTaskManager_CreateExecDeleteTask (0.20s) task_test.go:459: Error Trace: task_test.go:459 Error: "[&WaitRequest{ID:fakeTask,ExecID:,XXX_unrecognized:[],}]" should have 2 item(s), but has 1 Test: TestTaskManager_CreateExecDeleteTask Messages: Wait called unexpected number of times for "fakeTask"...

Our BuildKite is designed to run multiple tests from multiple pull requests in parallel to utilize the bare-metal host fully. Because of that it wouldn't work as a performance benchmark...