Kyle Evans
Kyle Evans
I made this to confirm whether this was how you wanted to approach #387. If it is, then I will implement the parsing for the other RR records on this...
That makes sense to me, but the old one would still return a linked list of the old ares_srv_reply structs right? We don't want to return the new one with...
Thanks for your help; I made ares_parse_srv_reply a wrapper for cares_parse_srv_reply. Is this on the right track for what you envisioned? I want to make sure before I start working...
I think this is getting pretty close, let me know what you think. I left some questions above, and I also want to point out that I made new types...
Hi all, No rush of course, but are you still willing to review this in the future?
So far this addresses numbers 1 and 2 on your list. I had a question about 4 which i put inline on the code above. I'll also continue working on...
Also, i made the ttl field of ares_uri_reply an unsigned int instead of an int, which isn't strictly related to this PR but I think it was a bug that...
@bradh352 I've reworked the srv replies to use an array and an iterator. Let me know if you like that pattern better or if you like the old linked list...
That's fine! I appreciate all your help.
@markdingo offered a patch for this back in 2013 here: https://c-ares.haxx.se/mail/c-ares-archive-2013-07/0005.shtml Looks like it didn't get traction at the time, and looks like that patch changed the structs directly which...