Kyle Oman

The camera tools don't output the camera parameters for the last frame requested but get stuck on the second-last because there's a `+1` missing in the argument of `np.arange`. Fixed...

Martini

18

Submitting Author: Kyle Oman (@kyleaoman) All current maintainers: (@kyleaoman) Package Name: martini One-Line Description of Package: MARTINI is a modular package for the creation of synthetic resolved HI line observations...

Miscellaneous issues in Docs

1

- [ ] In this docs page: https://petrofit.readthedocs.io/en/stable/photometry.html there is a bullet list near "four plots are displayed" that does not seem to have rendered correctly (though it looks fine...

Code Linting in Continuous Integration

2

Continuous integration should check that code conforms to a consistent style. Some suggestions: - [x] At a minimum check PEP8 compliance with a tool such as [flake8](https://flake8.pycqa.org/en/latest/). - [x] Recommend...

swiftgalaxy

44

Submitting Author: @kyleaoman All current maintainers: @kyleaoman Package Name: swiftgalaxy One-Line Description of Package: Load in particles of a simulated galaxy, rotate coordinates, easy spherical/cylindrical coordinates, access integrated properties, and...

I would suggest adding a mention of what restrictions there are on licenses that can be used for preprint submissions (including after publication) in the docs here: https://joss.readthedocs.io/en/latest/submitting.html#preprint-policy. Even if...

The `np.average` function returns incorrect output for the optionally-returned sum of weights when the input array and weights do not have the same shape (e.g. you want the weighted sum...

`ndarray.reshape` prototype mismatch

3

As of numpy 2.1 the `ndarray.reshape` function has a new keyword argument `copy` (https://numpy.org/doc/2.1/reference/generated/numpy.ndarray.reshape.html) that is not reflected in the `unyt_quantity` implementation: https://github.com/yt-project/unyt/blob/f2286620e2217c8f44ae46d99cfe7e22bf4557dd/unyt/array.py#L2273