Kyle Oman

Results 22 comments of Kyle Oman

@hamogu As far as I understand the astropy community packages look for use of astropy features where this is relevant, which is not really the case for this package. For...

Just so I can keep track: - [x] Please emphasize the requirement for NumPy >= 2.0 - [x] Please add installation instructions - [x] Please show a brief example of...

@coatless I think that I've addressed all of your requested changes now! I edited the submitted version to `2.1.1`, just made a release including the updates.

@crhea93 pleased to meet you! (A fellow Canadian, perhaps? I'm from Ottawa.) This is my second pyopensci submission so I have some idea of the lay of the land, although...

@blakeaw I think that I've now addressed all of the issues that you've raised so far. SWIFTSIM/swiftgalaxy#53 is still open but it seems like the caesar maintainers have picked it...

@crhea93 I'm just back from some holiday and wanted to bump this again, not sure what you want to do about the pending second review at this stage.

> Would you consider a modification to the data retrieval method in `demo_data.py` to use something more cross-platform like `requests` instead of `wget`? This is a good suggestion - could...

The last of the issues raised so far is now [basically solved](https://github.com/SWIFTSIM/swiftgalaxy/pull/67) (pending some code reviews, merges and publishing releases). @cmillion @blakeaw it would be appreciated if we could bring...

Actually this is not a problem - when I implemented this we decided that the difference in units was acceptable, and the test is written this way. In the "failure"...

At a glance I'd say that it's that some calls to `multiply` have been replaced with `square`. Easy to see how this would affect `std`, and since the special handling...