Kai Yen
Kai Yen
I wanted to try this with a real project before providing feedback but didn't get a chance to over the weekend and still wanted to send some thoughts back... This...
Some additional notes I forgot to add to the PR... - The tests require an airtable account and clone of this base to run: https://airtable.com/shr16Xd8glUk90c4P - Airtable does not provide...
If anyone comes across this PR while looking for an Airtable adapter, you can use this separate npm package until this is merged (or in case it is never merged).......
@balazsorban44 thank you for reviewing the PR! I could move everything into a single file at the expense of a cognitive complexity of 30+ and about 200 lines of code...
I combined this into fewer files as suggested by @balazsorban44. I believe everything has been addressed except for the tests requiring an airtable account and .env to store api key...
I suggest you consider bumping the version of pgvector to 0.70 since that is the latest.
I created a PR that I think fixes this. I'd love some feedback from anyone on how this could be better... https://github.com/drizzle-team/drizzle-orm/pull/1316
Thanks @jakeleventhal, I see a fix went out in 0.29.2. This issue can be closed.
I believe the reason for issue 2 in the original post and @msalahz issue is withAuth middleware ONLY supports JWT and not database sessions. This page buried in the docs...
> https://github.com/script-kit/app/releases/tag/v3.1.1 > > @kyen99 @burhanrashid52 That link will take you to the v3 beta releases. We've tested on a bunch of machines and everything seems good to go. Please...