Ryan Krattiger
Ryan Krattiger
Just following up here, I am working on the ecp-data-vis-sdk in spack and we were looking at packages that would have ROCm enabled. I have seen this in the works...
Whoever reviews this, I have some questions on a couple things - there is a test case name option `levels=` but I couldn't see how that was used, so it...
@drwells Hey just checking in to see if you have had a chance to review this.
Another question I had for the tests was on the connection between the examples and the tests. Are the test drivers (near) duplicates of the examples?
@drwells > Another thing that isn't right with this is that tests are considered to pass if they successfully run - i.e., a failing diff doesn't cause the whole test...
@drwells So I have done some digging and asking around and it seems the most reliable way to make sure all of the tests are added, and not skipped due...
@drwells I re-pushed fixes for CPU balancing, fixed the logic around adding restart and check tests, and added a cleanup tests. The issue with the symlinked tests is still there....
Another edge case that isn't behaving the way I would like is the `expect_failure=true` tests. If the case exits with an error code it is pretty easy to make these...
> What's the issue with that case? If we abort then we have a nonzero exit code anyway. The issue seems to be the `WILL_FAIL` property on the test doesn't...
I just noticed that this test was missing an input, but it has an output: `interpolate_velocity_02` I am not sure how you want this case to be handled. Currently I...