Kyle Welch

Results 11 comments of Kyle Welch

I tried to add personal as the assignee, but it didn't work. 🤷‍♂️

Looks good, we should get this added to all of our stuff. Much easier to write docs in context of the code when possible.

@deremer, We are currently, getting that type from our compiler options being set to use `dom`. https://github.com/eventbrite/eventbrite-sdk-javascript/blob/master/tsconfig.json#L3 Beyond that we are looking at the proper way to export this within...

Agreed, that was my exact thought process. Let's leave this open to until we have a proper solution for node. Thank you for confirming!

I have looked into this further and the types for `isomorphic-fetch` have been deprecated in favor or using `lib: ['dom']`. https://github.com/DefinitelyTyped/DefinitelyTyped/commit/4cb5f8c313ec0a2671735cb19a8faf8bfdf435ad I don't full agree with this, but that appears...

Thank you for the request. We agree with the need for this feature. We are looking into the most optimal way to implement this.

I mostly forgot about that. We could put a bot in place for title linting for PRs only. Here is my original comment on the bot that we could use....

I think we mitigate that need by exclusively using squash merge, right?

I don't think the effort required for this change is near the value gained by it. While the spaces are slightly more readable, in my opinion once you get to...

@miglesiasEB How do you feel about making an announcement at FE Guild and we have a post here people can _react_ to with their vote. (ie. ❤️ = leave as...