Kexin Wang

The code currently only checks the existence of `tensorflow` but something like `tensorflow-text`. However, if one goes to Google's Colab, where only `tensorflow` is installed, there will be an import...

Related issue https://github.com/castorini/pyserini/issues/431 I also found using `SimpleSearcher.search` might lead to memory leak. I did an experiment of BM25 search with 5K queries over `msmarco-v1-passage`. With all Pyserini search results...

Make the local-minimal version runnable again

2

# What does this PR do? It seems that some new lines have been added and the current local minimal version cannot run successfully. This PR fixes the issue. Changes:...

The argument variable should be named something like `names` but `nids`: https://github.com/UKP-SQuARE/square-core/blob/41e9c5875c3f30da9cc6a9cf7c9c35e78c1a878a/datastore-api/app/routers/kgs.py#L331-L355

feature required: `add_node`, `add_edge` instead of `add_document`

1

We have no methods for adding nodes/edges. The current code relies on add_document https://github.com/UKP-SQuARE/square-core/blob/2ffed37ad32c7912c63bc6601c36bd2307fb0a74/datastore-api/app/routers/kgs.py#L270 It could be better to add new methods in the kg_connector

Unclear method name `extract_nodes`

1

The method name cannot reflect its function clearly: https://github.com/UKP-SQuARE/square-core/blob/3f5d675b5c70aeebf7f3855e73c3bff00d837dee/datastore-api/app/core/kgs/connector.py#L201-L219 And why do we need this?

Changes: - create mode 100644 sample-data/build.py: Building the sample data (from BeIR/scifact) - create mode 100644 sample-data/scifact/corpus.jsonl: - create mode 100644 sample-data/scifact/qrels/test.tsv: - create mode 100644 sample-data/scifact/queries-test.tsv: - create mode...

New feature: Report query latencies and index size

1

This PR adds a new feature: The query latency details will be tracked and reported; the index size will be also reported. Changes: - `modified: examples/inference/distilsplade_max/beir_scifact/all_in_one.sh`: **Check out [this example](https://github.com/thakur-nandan/sprint/blob/39e9ec30e677a5d5a2185d8d942657e43047b8a5/examples/inference/distilsplade_max/beir_scifact/all_in_one.sh#L22-L131)...

We might need to run something like [black](https://black.readthedocs.io/en/stable/) to format the code