Kunal Tyagi
Kunal Tyagi
> then change the compiler options for each version you want to build in CMake That would not be ideal (for my case, but a sound advice). Ideally, I would...
In the macros added, it's impossible to follow `macro argument should be enclosed in parentheses [bugprone-macro-parentheses,-warnings-as-errors]` since the macro arguments are the class name and the visibility type. Thoughts? ```cpp...
Hopefully fixed the first. Regarding the second error, please find my analysis in the comment above yours (https://github.com/nlohmann/json/pull/2843#issuecomment-869672937)
Rebased, and also refactored the code to make the macros a bit less offensive
Almost all tests are passing. Current issue: ``` C:\projects\json\tests\src\unit-udt_macro.cpp(413): error C2220: warning treated as error - no 'object' file generated [C:\projects\json\tests\test-udt_macro_cpp11.vcxproj] C:\projects\json\tests\src\unit-udt_macro.cpp(413): warning C4503: 'doctest::detail::instantiationHelper': decorated name length exceeded, name...
All checks pass. PTAL
Are there any more blockers? 😅
I think the sole unaddressed comment explicitly states that I don't need to take any action. What issues are remaining?
Seems to be not available. Btw, can we change the label on the PR?
If the action fails, I wish to use another action to create a comment to help the user understand how the PR title should be formatted. Hopefully, this makes sense