kumari tanushree

Results 12 comments of kumari tanushree

### Acceptance Criteria: - Kapp will have new annotation called `kapp.k14s.io/max-duration` which will accept `duration string` (like [ParseDuration](https://pkg.go.dev/time#ParseDuration) ) as value. - Resource which has annotation `kapp.k14s.io/max-duration` set, kapp on...

Suggestion: I think it would be good if you can add little more description like: how the new output will look like? You can add some example output.

Acceptance criteria: After going through all the slack discussion found that copying `status` from existing to new resource(current default behaviour of kapp) is not needed. Hence as a solution for...

Sure @joaopapereira , will have a look into this in detail and get back to you soon.

@100mik > I think the example you shared above is perfect ! It can be captured in an E2E test in a similar manner (like the existing one) To have...

> @kumaritanushree @100mik Before committing to an E2E test scenario, I wanted to explore a more unit-style approach. After discovering all the required types and APIs I drafted a table-driven...

> `default_template_rules_test.go` now tests the newly added template rules for kapp-controller's resources. @mamachanko I think file name should be default_test.go so that if in future if required we can add...

@nikunj-badjatya Really sorry but I am not working on dkron since a year. I do not have access to dkron manifests now what I was using a year back.

@neil-hickey Because of other high priority tasks did not get time to look into this. Based on the priority of tasks will try to look back into it.

@hans-d I tried to reproduce the issue with config ``` apiVersion: vendir.k14s.io/v1alpha1 kind: Config directories: - path: sponnet contents: - path: xyz http: url: https://github.com/spinnaker/sponnet/archive/refs/tags/v1.26.0.tar.gz123 ``` First I run without...