Jakub Ráček
Jakub Ráček
I don't think that this is an issue of this package. Whoever has this issue: 1) Make sure you have a default node version set. For example (`nvm alias default...
Looking forward for this 👍
@JamesH1978 It should be fine now. Let me just test everything once more and I think it's ready unless you have some objections.
@Sineos Thanks. I looked into the implementations and they modify a lot the 'input' value parameter which then stores scaled value as `last_value`. This would cause troubles for say Mainsail...
I went though the discussions again. It doesn't seem like anybody has a problem with this per-se more so the way it was implemented that there were too many variables....
I've renamed the `off_below` to `min_power` and updated any references to it. https://github.com/Klipper3d/klipper/assets/16261998/6bb516ee-1255-4496-9be9-3b5744271a25
> Isn't this something that can be implemented as macro? why a native way? I wrote in description of the PR. I can't see any reason why in the context...
Indeed. Also searching for M106 the internet says `Set Fan Speed` not `Set fan PWM`. So PWM in this context should be abstracted away from the client
Thanks for testing, it stalled on merging. There isn't anybody assigned to this with the rights to merge this unfortunately. I don't think there is anything more to discuss or...