Karthik Thayyil

Results 24 comments of Karthik Thayyil

@joemcgill I started analysing https://github.com/WordPress/gutenberg/issues/45601 But the original ticket(related work) seems to be fixed. I see a PR for this but there is no Trac Ticket for this can you...

Issue - https://github.com/WordPress/gutenberg/issues/45601 `register_block_core_template_part accounts` for `~7%` of load time `~80ms`. The function calls build_template_part_block_variations, which accounts for `99%` of the function time. This function is called in almost every...

@joemcgill Should we mark https://core.trac.wordpress.org/ticket/58196 as done, given that we have a static variable approach in place? Also, should we create a ticket to study `_get_block_templates_files` in favour of https://core.trac.wordpress.org/ticket/58196#comment:30

@joemcgill Can we add it here as it is related to the theme_json effort? https://core.trac.wordpress.org/ticket/61112#ticket

@joemcgill With the latest changes we are getting a consistent 2.5% improvement without breaking anything. | Performance Metric | Trunk | PR | Improvement (%) | |----------------------------------------|---------------------|---------------------|----------------------| | Response Time...

> Oh, by the way. It'd be nice if this change would have been done first in the Gutenberg codebase. The value that provides is immense to all of us,...

> Thanks @kt-12. When running some profiling data on this approach, I'm not seeing much benefit to adding a cache at this point in the execution process. > > Comparing...

@asvinb @joemcgill I have updated the the first line for case where there is just a single country to be match to that of multiple countries "Google will optimize your...

@eason9487 I have addressed your review comment. I have also fixed [E2E](https://github.com/woocommerce/google-listings-and-ads/actions/runs/11102033157/job/30840946684) to reflect the current flow.