kshepherd

Results 162 comments of kshepherd

@tdonohue there are some tests still failing with this and the DSpace PR, as well as some possible tidy-up needed to the way I wired up request GET and POST...

The 2 failed 16.x tests are related to failed e2e tests, a connection timeout trying to get search or mydspace config for workspaceitems. I don't know how this would be...

I solved the display issue that I had noted in my first PR description. Describing my fix below for reviewers' attention: There is an action + effect combo “CleanDetectDuplicateSection”. It’s...

I am strongly in favour of adding i18n keys to submission forms! From what I've seen in my recent work, there wouldn't be any problems implementing this and it would...

A further note here that all the form components pass `label` through a translate pipe, so this is already possible, all we're missing is to make keys and move the...

As per notes on https://github.com/DSpace/dspace-angular/pull/1670 the above approach was rejected. The changes in https://github.com/DSpace/DSpace/pull/8322 (also closed) may or may not be useful to somebody else who implements translation in the...

@lap82 thanks for this port - in general I think we're trying to restrict 5.11 to just security fixes now but I think this one "breaks" DSpace enough and it's...

doing the "close and reopen" tick to kick off the new travis CI build

Thoughts on names: The important aspects are that these Group memberships are assigned based on data inspected at login, and are ephemeral / session-based - I've seen people get confused...

Note, there is still a commented-out line in the spring configuration that implies it is still possible to scope by community or collection handle: `` Until this is fixed we...