Sergey Kovalevich

Results 5 comments of Sergey Kovalevich

Something like: ``` if (SBE_BOUNDS_CHECK_EXPECT((position > m_bufferLength), false)) { SBE_BOUNDS_CHECK_ERROR("buffer too short [E100]"); } ``` sbe.h ``` #ifndef SBE_BOUNDS_CHECK_ERROR # define SBE_BOUNDS_CHECK_ERROR(msg) { throw std::runtime_error(msg); } #endif ```

Do you skip/process all repeating groups prior to `NoInstAttrib`? ``` ... instdef.noEvents().skip(); // or auto group = instdef.noEvents(); while (group.hasNext()) { group.next(); ... // process group } // now your...

``` auto& instrumentData = const_cast(getInstrumentData(sym)); auto& instdef = std::get(instrumentData); ``` Looks like you try to reread a sbe object. If you once processed a message (repeating groups and variable length...

@takohack if you about [master](https://github.com/odygrd/quill/blob/9a270d5d6f57a3ac19451292e3a9f370fcd744b1/quill/include/quill/detail/spsc_queue/BoundedQueue.h#L46C1-L47C97) version of `BoundedQueue` I don't known. Also there is [unnecessary](https://github.com/odygrd/quill/blob/9a270d5d6f57a3ac19451292e3a9f370fcd744b1/quill/include/quill/detail/spsc_queue/BoundedQueue.h#L49) check of variable which already is pow2. I think it's not finished refactoring. @odygrd ^^

Yes, it is the CH552-48-LPR!