Kevin Schwarzwald

Would like to second @engmubarak48 ; this problem was fixed for me when I changed the environment.yaml file I was using to generate the environment to include `jupyter` and `jupyterlab`....

I think the failing check is something that came from the latest main branch update, so once that gets resolved, I'll merge this barring any other comments?

does anything else need to happen before it's cleared for merging btw?

Yeah, I guess in this case from a legibility standpoint, the fact that `.values` 'changes' (from the user point of view) the form (and `type`) of the data from a...

A related issue is that this allows you to (possibly inadvertently) circumvent certain xarray safeguards, like the `TypeError` around not being able to modify `IndexVariables`: ``` # Create sample dataset...

> Yes! That would be a welcome contribution. Sounds good, I'll prep a PR

Thanks for that example! I think personally I'm in favor of just putting in a better error message; `xagg` probably shouldn't assume a CRS of any input to avoid any...

Yeah fair - Looks like there are a few causes of that 1. Use of `.dims` instead of `.sizes` (easy enough to fix) 2. Not suppressing the `print()` calls 3....

https://github.com/ks905383/xagg/pull/63#issuecomment-1954112998 One subfunction still doesn't have `silent` piped into it. This is through this line https://github.com/ks905383/xagg/blob/db8df95664c2ccceae4ad1f7dd5fb711af07bc38/xagg/core.py#L616, which should have `silent=silent` show up in the `subset_find()` call. @helsharif can you confirm...

Thanks for the PR and your work on this! I'm especially excited for the performance updates, and I'm glad that this package is useful to folks. Just a couple of...