Krzysztof Czurylo

Results 18 comments of Krzysztof Czurylo

--- Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved. --- *Comments from [Reviewable](https://beta.reviewable.io/reviews/pmem/syscall_intercept/79#-:-LA-9uSW2Up6xnycz-RU:bnfp4nl)*

So, this info could be added to the source file and/or to some README. --- Reviewed 3 of 3 files at r1. Review status: all files reviewed at latest revision,...

Regarding the pool statistics API, I think this is something that "pmemobj_ctl()" could do, right? "pmempool info" may use this API to provide some more data. Once it's ready, we...

If you can load it directly from the TEST file, you could just put `. ./config.sh` into each TEST file in given directory and that's it. Or, we can do...

I think the example does not illustrate the issue, as it acquires the same lock twice, so the complexity is O(n). Any example of the real world scenario when it...

Sure, I got it. What I meant is that the better example for this would be: ``` c TX_BEGIN(pop) { for (int i = 0; i < N; i++) TX_BEGIN_LOCK(pop,...

What are we going to do with this issue? Can we close it as "not a bug"?

The `pmempool rm` command is just a a convenience wrapper around `rm` or `unlink`. If you make a mistake (i.e. `rm -rf $HOME`), sorry... The only special cases it handles...

It has been discussed a long time ago. The key problem is to guarantee transaction atomicity across multiple pools. I mean, if the transaction is torn by a power failure,...