krutikavk
krutikavk
Hi @srinivasankavitha Can you take a look at the PR
> Thanks for the PR! Will do later this week. Thanks @srinivasankavitha. I am also working on updating Kotlin codegen. What is the difference between `generators/kotlin` and `generators/kotlin2`--should I be...
> yeah that flag is specific to kotlin2. Yes, it would be great of you can add to both since we try to maintain feature parity as much as possible....
Linting and some unit tests fixed, please check @srinivasankavitha
@srinivasankavitha I see linting fixed many files across the repo--can you please check if this change is as required by the build? Since the last failure [7a1d567](https://github.com/Netflix/dgs-codegen/pull/664/commits/7a1d5678bb0b017a41dc056824b50d197b457026), added one more...
> @krutikavk - I'm reviewing your PR and have a few questions: > > 1. Can you provide an example of how this newly generated class will be used? Does...
> > > @krutikavk - I'm reviewing your PR and have a few questions: > > > > > > 1. Can you provide an example of how this newly...
> Oh, one other issue, is that mapping for Kotlin types doesn't use setters at all currently. There is a [ticket open](https://github.com/Netflix/dgs-framework/issues/1057) for that, I think we can fix it...
Thanks all for weighing in, I ll will update the PR for a fresh review
Hey @kilink @srinivasankavitha @paulbakker Sorry for the delay, I have updated the PR with the following changes as per discussions: 1. Generate boolean fields for Java data classes by default,...