Kumar Shubham
Kumar Shubham
I tried with npm and also with yarn. I don't think this matters much does it? And anyways, it failed in both the cases. :(
Fine the tests are passing now. I just re cloned the repo 👍
Okay, I'll open an issue listing all the work that should be done ! 👍
@atfornes , I started out with the first issue, and it turned out that the issue was more related to a [bug](https://github.com/Grasia/teem/issues/374) that prevailed before starting the task. Although, the...
+ Separated HTML and CSS in respective files + Added weight to the title + Checked indentation properly
@atfornes Why is this build failing now! It says async callback was not invoked within given time 😢 😢
@divyanshu-rawat Here is the **modal.scss** at **src/sass/modal.sass** file which has the details of the modal dialog class. I added 5% to padding and it did the job!
@atfornes , what about this issue? Should I make the padding changes, or its not needed?
[`join.js:40`](https://github.com/Grasia/teem/blob/master/src/js/directives/join.js#L40) What is joinModel? Should it be joinModal?
Yes it should be joinModel only. I was also wondering because it just stopped working! I should've have done that search before asking! 👍