Christophe Marin

Build issue with glslang 11.4.0

8

Gammaray fails to build on openSUSE since a recent update from 11.2.0 to 11.4.0. error log below: ``` [ 86s] [ 2%] Generating widget_wireframe.frag_widget_wireframe.geom_widget_wireframe.vert_validate_program_3.stamp [ 86s] cd /home/abuild/rpmbuild/BUILD/gammaray-2.11.2/build/plugins/widgetinspector/assets/shaders && /usr/bin/glslangValidator...

VTK 8 is unsupported

2

VTK 8.xx is out but it can't be used to build Gammaray. the VTK build system says version 8 is not compatible with older major versions (confirmed locally): > >...

The 'limits' header must be included explicitly.

Wrong logic when looking for Qt

12

This was mentioned in #830 but deserves its own report https://github.com/KDAB/GammaRay/blob/3.0/CMakeLists.txt#L424-L439 has multiple issues. 1 - It can't find Qt 6 2 - the set package properties line does nothing...

Kraft 0.95 hardcodes some background colors

2

Screenshots showing the issues:   When using dark color schemes, the hardcoded colors make some text barely visible

Related: https://github.com/gabime/spdlog/pull/3130 ``` [ 18s] FAILED: src/CMakeFiles/kddockwidgets.dir/LayoutSaver.cpp.o [ 18s] /usr/bin/c++ -DBUILDING_DOCKS_LIBRARY -DFMT_SHARED -DKDDW_FRONTEND_QT -DKDDW_FRONTEND_QTQUICK -DKDDW_FRONTEND_QTWIDGETS -DKDDW_HAS_SPDLOG -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_KEYWORDS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_OPENGL_LIB -DQT_QMLBUILTINS_LIB...

library version and soversion weren't updated

9

Version and soversion weren't updated before the 6.0.0 release: See https://github.com/assimp/assimp/blob/v6.0.0/CMakeLists.txt#L248 and https://github.com/assimp/assimp/blob/v6.0.0/CMakeLists.txt#L106 Result: ``` [ 171s] -- Installing: /home/abuild/rpmbuild/BUILD/assimp-6.0.0-build/BUILDROOT/usr/lib64/libassimp.so.5.4.3 [ 171s] -- Installing: /home/abuild/rpmbuild/BUILD/assimp-6.0.0-build/BUILDROOT/usr/lib64/libassimp.so.5 [ 171s] -- Installing: /home/abuild/rpmbuild/BUILD/assimp-6.0.0-build/BUILDROOT/usr/lib64/libassimp.so...

CMake 4 dropped support for CMake versions