Kristina Pathak

Results 35 comments of Kristina Pathak

@Aneurysm9, I added the target you recommended - it runs as a part of basic checks: https://github.com/open-telemetry/opentelemetry-operator/actions/runs/3046982755/jobs/4910456529

Golang-ci is not running on target allocator code. I will be working on getting golang-ci to run on all go modules in the repo and fixing other lint issues in...

@pavolloffay, how was the configuration in .golangci.yaml decided? Other opentelemetry repos have golangci configured in a different way than this one, most notably for `govet`: https://github.com/open-telemetry/opentelemetry-go-build-tools/blob/29a46c89ab69347be7d6f2c7f4f94135cb4d0d4f/.golangci.yml#L58 https://github.com/open-telemetry/opentelemetry-collector/blob/b1329c94b3b31b9ffa4091ab5066d6f091d71f41/.golangci.yml#L58 https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/d2490af3003387cc4b1baa5b55f7d748303d7a4b/.golangci.yml#L56 There are...

@pavolloffay, bringing the golangci.yaml into alignment with the golangci configs in opentelemetry-collector and opentelemetry-collector-contrib means even more lint fixes. I would rather disable `fieldalignment` in this PR, merge this, and...

Further lint work: https://github.com/open-telemetry/opentelemetry-operator/issues/1122

@pavolloffay, I think there is an issue from `Code standards (linting)` being in a matrix now: ``` Continuous Integration / Code standards (linting) (.) (pull_request) Continuous Integration / Code standards...

Hi @alexdresko, creating a ServiceMonitor for the collector may not work until the ports are included for the container (https://github.com/open-telemetry/opentelemetry-operator/issues/1011). I included my ServiceMonitor file as a part of the...

I plan to work on this. I'm not sure if the headless service is always needed? Regardless, I think we still need to add a label.

I investigated this more - I set up a pod monitor for the collector while running the collecter as a statefulset. The ports for the operator could be found in...

I believe this is a problem for both ServiceMonitor and PodMonitor but will try a ServiceMonitor scenario. 🙂