Kris Kwiatkowski
Kris Kwiatkowski
Linter reports variables used only in assembly as unused. Consider this very common code used in crypto libraries: ``` test.go: import "golang.org/x/sys/cpu" var hasBoth = cpu.HasBMI2 && cpu.HasADX ``` ```...
In current implementation ``ROL r`` is not supported - in x86 assembly this does shift by 1. Probably same thing for RCL, RCR and ROR
That's because of "The two attacks related to SHA-256-based parameters claiming category 5 security will need to be carefully considered when selecting which parameters of SPHINCS+ to standardize. In both...
After removing ``-Wno-stringop-verread -Wno-stringop-overflow`` I'm getting: ``` cd /home/kris/repos/pqc/build/src/kem/sike && /usr/bin/cc -DPQCLEAN_NAMESPACE=PQC_SIKEP434_CLEAN -DPQC_ASM=1 -I/home/kris/repos/pqc/public -I/home/kris/repos/pqc/src/common -I/home/kris/repos/pqc/src -I/home/kris/repos/pqc/3rd/cpu_features/include -I/home/kris/repos/pqc/src/kem/sike/src/common -I/home/kris/repos/pqc/src/kem/sike -Wno-ignored-qualifiers -Wall -Werror -Wextra -Wpedantic -Wshadow -Wno-variadic-macros -Wundef -Wunused-result -Wno-unused-command-line-argument -Wno-array-parameter...
After removing ``-Wno-array-parameter`` I'm getting some errors in kyber. probably no problem
We should use both: * https://github.com/dvyukov/go-fuzz for fuzzing interfaces (see how it's used here: https://github.com/mmcloughlin/cryptofuzz) * https://github.com/guidovranken/cryptofuzz : for checking against alternative implementation (see this https://guidovranken.com/2019/05/14/differential-fuzzing-of-cryptographic-libraries/). This one will be...
In some cases we will use assembly in order to optimize the code. We do need to test such code on multiple OS's as they may have different ABI (at...
The SP800-56Cr2, in section 2, specifies auxiliary shared secret ‘t’ that can be concatenated with a shared secret 'z' as specified by SP800-56A/B. Both, the value 'z' and 't' are...
Looking at https://pages.nist.gov/ACVP/draft-hammett-acvp-kas-kdf-hkdf.html#name-test-case-json-schema there seem to be a problem with that table. Namely, what should be in "JSON value" is in "JSON type" column (to put it simply, it is...
Looking at https://pages.nist.gov/ACVP/draft-hammett-acvp-kas-kdf-hkdf.html#name-test-case-json-schema Table 5 is missing: ``multiExpansion`` JSON Value of type bool.