Krishna (kc) Glick comments

Results 28 comments of


                                            Krishna (kc) Glick

Power-Up selected Pokémon x times

Maybe a powerup to max!

Connection Form Refactor - Connection Form Service

> Looks like the field for Connection Name input disappeared during connection creation. Should be fixed!

Connection Form Refactor - Connection Form Service

I've pulled out some portions of the code into #16303 and #16293. Those two, when merged, will generate some minor conflicts but will clean up this PR.

Connection Form Refactor - Connection Form Service

Thanks for the all-clear Edmundo! I'm going to merge this Monday, don't want to blow up on-call _just in case_

:window: :art: Connector Field UX Improvements

Looks like there's a conflict!

:window: :art: Connector Field UX Improvements

![Screen Shot 2022-09-13 at 9 47 23 AM](https://user-images.githubusercontent.com/4967694/189918241-89957f2f-98f6-462e-9099-0a01d6f9a718.png) The spacing seems off here. Also happens in the app.

:window: :art: Connector Field UX Improvements

![Screen Shot 2022-09-14 at 10 07 28 AM](https://user-images.githubusercontent.com/4967694/190176884-df14ad43-5fe3-4404-a584-8605612ce2a1.png) Could use just a little more spacing perhaps?

:window: :art: Connector Field UX Improvements

> > Could use just a little more spacing perhaps? > > @krishnaglick this PR is only focusing on the connector form, not the connection form. Did you maybe post...

:window: :art: Connector Field UX Improvements

Some conflicts here, probably easy fixes from the React 18 upgrade prep PR.

:window: :art: Connector Field UX Improvements

![Screen Shot 2022-09-15 at 9 43 45 AM](https://user-images.githubusercontent.com/4967694/190419742-279bffa2-cb03-4fd0-b9fa-c49b2bce84ef.png) ![Screen Shot 2022-09-15 at 9 45 27 AM](https://user-images.githubusercontent.com/4967694/190420654-1e863bfc-e18e-4c8f-9aba-ce247afbb527.png) Source creation page. This is in Firefox. Looks cleaner on Chrome.