Koray Koska

As stated in the JSONAPI documentation: > Note: Although recommended, sort fields do not necessarily need to correspond to resource attribute and association names. it is not required that sort...

Mocking Web3 request tests

4

Mock Web3 request tests instead of relying on Infura as this is obviously bad practice.

DynamicContractTests never run all tests

1

The DynamicContractTests always stop creating tests because of [this line](https://github.com/Boilertalk/Web3.swift/blob/master/Example/Tests/ContractTests/JSONContractTests.swift#L54). `contract.deploy` somehow always fails and because we just return there. We don't even notice when running the test suite. I...

Make from optional for createTransaction

1

The `from` value for the `createTransaction` function in `SolidityInvocation` should be optional just like in the `EthereumTransaction` initializer as it is not really required if you want to send a...

Change provided static contracts to return the value instead of `[String: Any]`

3

I am talking about `ERC20Contract` in this issue but it applies to all our static contracts. ### Problem Currently all functions we provide in `ERC20Contract` return a `SolidityInvocation`. This makes...

Code Quality

1

Make sure our code gets a good grade on codebeat.

Increase code coverage

1

The aim is not to increase the code coverage value but rather to make sure our code meets the specifications in as many cases as possible.

We need those types for fixed/ufixed in the upcoming contract abi module.

SwiftUIRouter using NavigationLink

6

We are using this library since starting the development of our app. It grew quite big and we start having smaller annoying issues that would not exist if it was...

Navigate navigates into void sometimes

3

Very randomly, without any consistency, I see that Navigate tries to navigate to a route, then chooses to make a wrong turn to the default route in the last step...